Bug 206454 - REGRESSION(r253636): [GTK] Mouse cursor changes using onMouseXYZ are erratic
Summary: REGRESSION(r253636): [GTK] Mouse cursor changes using onMouseXYZ are erratic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-17 15:41 PST by Lauro Moura
Modified: 2020-01-30 05:48 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.59 KB, patch)
2020-01-30 01:00 PST, Carlos Garcia Campos
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-01-17 15:41:02 PST
After r253636 (after bisecting) the two tests below started failing.

* fast/events/mouse-cursor-change.html:

```
@@ -10,13 +10,13 @@
 Cursor Info: type=Hand hotSpot=0,0
 
 Mouse down
+Cursor Info: type=Hand hotSpot=0,0
+
+Mouse hold down, move
 Cursor Info: type=Progress hotSpot=0,0
 
-Mouse hold down, move
-Cursor Info: type=Hand hotSpot=0,0
-
 Mouse up
-Cursor Info: type=Help hotSpot=0,0
+Cursor Info: type=Progress hotSpot=0,0
 
 PASS successfullyParsed is true
```

* fast/events/mouse-cursor-no-mousemove.html:

```
@@ -8,7 +8,7 @@
 
 TEST CASE: Mouse idle, change cursor should not fire mousemove event
 Cursor Info: type=Pointer hotSpot=0,0
-Cursor Info: type=Help hotSpot=0,0
+Cursor Info: type=Pointer hotSpot=0,0
 
 PASS successfullyParsed is true
```

Testing the first one in MiniBrowserGtk, it seems like the cursor keeps stuck to the style assigned in `onMouseMove`, with the other styles appearing briefly in a erratic manner.

Manual testing worked fine in Firefox and Epiphany 3.34 (WebKitGTK 2.26.2).
Comment 1 Carlos Garcia Campos 2020-01-30 01:00:51 PST
Created attachment 389233 [details]
Patch
Comment 2 Tim Horton 2020-01-30 01:15:50 PST
Comment on attachment 389233 [details]
Patch

Apologies!
Comment 3 Carlos Garcia Campos 2020-01-30 05:27:53 PST
Committed r255421: <https://trac.webkit.org/changeset/255421>