206451 – Remove std::lock_guard

Bug 206451 - Remove std::lock_guard

Summary: Remove std::lock_guard

Attachments
Patch (76.30 KB, patch) 2020-02-29 02:00 PST, Yusuke Suzuki	no flags	Details \| Formatted Diff \| Diff
Patch (80.08 KB, patch) 2020-02-29 02:13 PST, Yusuke Suzuki	no flags	Details \| Formatted Diff \| Diff
Patch (80.23 KB, patch) 2020-02-29 02:41 PST, Yusuke Suzuki	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Basuke Suzuki 2020-01-17 15:31:42 PST

We are on C++ 17. https://en.cppreference.com/w/cpp/thread/scoped_lock

Comment 1 Yusuke Suzuki 2020-01-17 15:47:32 PST

https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement
Our requirement is GCC7. So, we can use it.
https://www.gnu.org/software/gcc/gcc-7/changes.html

Comment 2 Basuke Suzuki 2020-01-17 16:39:14 PST

It generates exactly same code. We can safely replace this. https://godbolt.org/z/p-KTwc

Comment 3 Yusuke Suzuki 2020-02-29 02:00:17 PST

Created attachment 392054 [details]
Patch

Comment 4 Yusuke Suzuki 2020-02-29 02:13:41 PST

Created attachment 392055 [details]
Patch

Comment 5 Yusuke Suzuki 2020-02-29 02:41:48 PST

Created attachment 392057 [details]
Patch

Comment 6 Anders Carlsson 2020-02-29 07:02:41 PST

Comment on attachment 392057 [details]
Patch

OK.

Comment 7 Yusuke Suzuki 2020-02-29 20:13:35 PST

Comment on attachment 392057 [details]
Patch

Thanks

Comment 8 WebKit Commit Bot 2020-02-29 21:01:37 PST

Comment on attachment 392057 [details]
Patch

Clearing flags on attachment: 392057

Committed r257688: <https://trac.webkit.org/changeset/257688>

Comment 9 WebKit Commit Bot 2020-02-29 21:01:40 PST

All reviewed patches have been landed.  Closing bug.

Comment 10 Radar WebKit Bug Importer 2020-02-29 21:02:17 PST

<rdar://problem/59925404>