RESOLVED FIXED 206441
Some iOS tests using UIHelper.dragFromPointToPoint() are flakey 
https://bugs.webkit.org/show_bug.cgi?id=206441
Summary Some iOS tests using UIHelper.dragFromPointToPoint() are flakey
Simon Fraser (smfr)
Reported 2020-01-17 13:39:21 PST
Some iOS tests using UIHelper.dragFromPointToPoint() are flakey
Attachments
Patch (7.08 KB, patch)
2020-01-17 13:43 PST, Simon Fraser (smfr) 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-01-17 13:43:00 PST
Created attachment 388085 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-01-17 13:43:03 PST
<rdar://problem/56714139>
Wenson Hsieh
Comment 3 2020-01-17 13:47:26 PST
Comment on attachment 388085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388085&action=review r=mews > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:434 > +static NSDictionary *dictionaryForFingerEventWithContentPoint(CGPoint point, NSString* phase, Seconds timeOffset) Nit - * on other side. > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:459 > + NSDictionary* touchDownInfo = dictionaryForFingerEventWithContentPoint(startPoint, HIDEventPhaseBegan, 0_s); Nit - * on other side. > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:467 > + NSDictionary* liftUpInfo = dictionaryForFingerEventWithContentPoint(endPoint, HIDEventPhaseEnded, Seconds(durationSeconds)); Ditto.
Wenson Hsieh
Comment 4 2020-01-17 13:48:41 PST
Comment on attachment 388085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388085&action=review > Tools/ChangeLog:14 > + and dispatching via -[HIDEventGenerator HIDEventGenerator:]. This spawns a thread to Nit - I think you meant to write "sendEventStream:completionBlock:".
Simon Fraser (smfr)
Comment 5 2020-01-17 18:23:58 PST
https://trac.webkit.org/changeset/254786/webkit
Note You need to log in before you can comment on or make changes to this bug.