Bug 206441 - Some iOS tests using UIHelper.dragFromPointToPoint() are flakey
Summary: Some iOS tests using UIHelper.dragFromPointToPoint() are flakey
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-17 13:39 PST by Simon Fraser (smfr)
Modified: 2020-01-17 18:23 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.08 KB, patch)
2020-01-17 13:43 PST, Simon Fraser (smfr) 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-01-17 13:39:21 PST 
Some iOS tests using UIHelper.dragFromPointToPoint() are flakey
Comment 1 Simon Fraser (smfr) 2020-01-17 13:43:00 PST 
Created attachment 388085 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-01-17 13:43:03 PST 
<rdar://problem/56714139>
Comment 3 Wenson Hsieh 2020-01-17 13:47:26 PST 
Comment on attachment 388085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388085&action=review

r=mews

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:434
> +static NSDictionary *dictionaryForFingerEventWithContentPoint(CGPoint point, NSString* phase, Seconds timeOffset)

Nit - * on other side.

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:459
> +    NSDictionary* touchDownInfo = dictionaryForFingerEventWithContentPoint(startPoint, HIDEventPhaseBegan, 0_s);

Nit - * on other side.

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:467
> +    NSDictionary* liftUpInfo = dictionaryForFingerEventWithContentPoint(endPoint, HIDEventPhaseEnded, Seconds(durationSeconds));

Ditto.
Comment 4 Wenson Hsieh 2020-01-17 13:48:41 PST 
Comment on attachment 388085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388085&action=review

> Tools/ChangeLog:14
> +        and dispatching via -[HIDEventGenerator HIDEventGenerator:]. This spawns a thread to

Nit - I think you meant to write "sendEventStream:completionBlock:".
Comment 5 Simon Fraser (smfr) 2020-01-17 18:23:58 PST 
https://trac.webkit.org/changeset/254786/webkit