Bug 206437 – REGRESSION: ( r254256 ) [ Mojave wk2 ] http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-gpuprocess.html is a flaky failure

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Truitt Savell]

http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-gpuprocess.html 

Description:
This test has been failing sense its introduction in https://trac.webkit.org/changeset/254256/webkit

History:
https://results.webkit.org/?suite=layout-tests&test=http%2Fwpt%2Fmediarecorder%2FMediaRecorder-AV-audio-video-dataavailable-gpuprocess.html

Diff:

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-gpuprocess-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-gpuprocess-actual.txt
@@ -1,4 +1,4 @@
 
 
-PASS Verify MediaRecorder is working in GPUProcess 
+FAIL Verify MediaRecorder is working in GPUProcess assert_true: the blob should contain some buffers expected true got false

[Radar WebKit Bug Importer]

<rdar://problem/58692880>

[youenn fablet]

Cannot reproduce currently.
One hypothesis is that we call stopRecording which after sometime and hopping through threads will set m_isStopped and m_hasStartedWriting to false.
Any further call to fetchData will then fail.
This might happen with GPUProcess since the stopRecording and fetchData calls are two IPC messages.

[youenn fablet]

Created attachment 388222 [details]
Patch

[Eric Carlson]

Comment on attachment 388222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388222&action=review

> Source/WebCore/ChangeLog:10
> +        If too much time happened betweent he two call,s stopRecording will trigger setting m_isStopped and m_hasStartedWriting to false.

s/call,s/calls/

[youenn fablet]

Created attachment 388234 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 388234 [details]
Patch for landing

Clearing flags on attachment: 388234

Committed r254823: <https://trac.webkit.org/changeset/254823>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.