Bug 206421 - [EWS] Print disk space usage for windows bots
Summary: [EWS] Print disk space usage for windows bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-17 09:19 PST by Aakash Jain
Modified: 2020-01-18 07:19 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.77 KB, patch)
2020-01-17 09:24 PST, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (2.43 KB, patch)
2020-01-17 09:34 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-01-17 09:19:43 PST
We added build-step to print bot configuration in EWS in https://trac.webkit.org/changeset/240680/webkit

On windows, we should also print disk space usage. It would help in debugging disk space issues.
Comment 1 Aakash Jain 2020-01-17 09:24:47 PST
Created attachment 388046 [details]
Patch
Comment 3 Aakash Jain 2020-01-17 09:34:12 PST
Created attachment 388048 [details]
Patch
Comment 4 Jonathan Bedard 2020-01-17 09:37:28 PST
Comment on attachment 388048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388048&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:1888
> +    command_list_win = [['df', '-hl']]

Shouldn't this go into command_list_generic? Do we have a 4th class of machines?
Comment 5 Aakash Jain 2020-01-17 09:40:45 PST
Comment on attachment 388048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388048&action=review

>> Tools/BuildSlaveSupport/ews-build/steps.py:1888
>> +    command_list_win = [['df', '-hl']]
> 
> Shouldn't this go into command_list_generic? Do we have a 4th class of machines?

Yeah, the 4th category is wincairo. We don't want to run this command on wincairo since I believe wincairo doesn't use cygwin and windows doesn't have df command.
Comment 6 WebKit Commit Bot 2020-01-17 16:32:18 PST
The commit-queue encountered the following flaky tests while processing attachment 388048 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-01-17 16:32:54 PST
Comment on attachment 388048 [details]
Patch

Clearing flags on attachment: 388048

Committed r254777: <https://trac.webkit.org/changeset/254777>
Comment 8 WebKit Commit Bot 2020-01-17 16:32:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-01-17 16:33:15 PST
<rdar://problem/58700332>
Comment 10 Aakash Jain 2020-01-18 07:19:38 PST
Deployed on the production server.

Working fine, e.g.: https://ews-build.webkit.org/#/builders/10/builds/4263/steps/2/logs/stdio