Bug 206418 - Drop dead code related to local storage prewarming
Summary: Drop dead code related to local storage prewarming
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-17 08:52 PST by Chris Dumez
Modified: 2020-01-21 09:56 PST (History)
10 users (show)

See Also:

Attachments
Patch (5.29 KB, patch)
2020-01-17 08:55 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-01-17 08:52:17 PST 
Drop dead code related to local storage prewarming. Sihui neutered it in <https://trac.webkit.org/changeset/248734> but did not remove the code.
Comment 1 Chris Dumez 2020-01-17 08:55:08 PST 
Created attachment 388044 [details]
Patch
Comment 2 WebKit Commit Bot 2020-01-17 10:45:03 PST 
The commit-queue encountered the following flaky tests while processing attachment 388044 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2020-01-17 10:45:39 PST 
Comment on attachment 388044 [details]
Patch

Clearing flags on attachment: 388044

Committed r254753: <https://trac.webkit.org/changeset/254753>
Comment 4 WebKit Commit Bot 2020-01-17 10:45:40 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-01-17 10:46:14 PST 
<rdar://problem/58687658>
Comment 6 Sihui Liu 2020-01-21 09:36:02 PST 
It's not dead... My change was about the prewarm message. By creating localStorage ahead, web process connects to the storage area in network process, and network process does the prewarm there.
Comment 7 Chris Dumez 2020-01-21 09:50:34 PST 
(In reply to Sihui Liu from comment #6)
> It's not dead... My change was about the prewarm message. By creating
> localStorage ahead, web process connects to the storage area in network
> process, and network process does the prewarm there.

Ok, I will revert but add a comment then. It is too subtle otherwise.
Comment 8 Chris Dumez 2020-01-21 09:53:01 PST 
Reverted r254753 for reason:

It turns out this is not dead code

Committed r254857: <https://trac.webkit.org/changeset/254857>
Comment 9 Chris Dumez 2020-01-21 09:56:24 PST 
<https://trac.webkit.org/changeset/254858>