WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
206418
Drop dead code related to local storage prewarming
https://bugs.webkit.org/show_bug.cgi?id=206418
Summary
Drop dead code related to local storage prewarming
Chris Dumez
Reported
2020-01-17 08:52:17 PST
Drop dead code related to local storage prewarming. Sihui neutered it in <
https://trac.webkit.org/changeset/248734
> but did not remove the code.
Attachments
Patch
(5.29 KB, patch)
2020-01-17 08:55 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2020-01-17 08:55:08 PST
Created
attachment 388044
[details]
Patch
WebKit Commit Bot
Comment 2
2020-01-17 10:45:03 PST
The commit-queue encountered the following flaky tests while processing
attachment 388044
[details]
: editing/spelling/spellcheck-attribute.html
bug 206178
(authors:
g.czajkowski@samsung.com
,
mark.lam@apple.com
, and
rniwa@webkit.org
) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3
2020-01-17 10:45:39 PST
Comment on
attachment 388044
[details]
Patch Clearing flags on attachment: 388044 Committed
r254753
: <
https://trac.webkit.org/changeset/254753
>
WebKit Commit Bot
Comment 4
2020-01-17 10:45:40 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5
2020-01-17 10:46:14 PST
<
rdar://problem/58687658
>
Sihui Liu
Comment 6
2020-01-21 09:36:02 PST
It's not dead... My change was about the prewarm message. By creating localStorage ahead, web process connects to the storage area in network process, and network process does the prewarm there.
Chris Dumez
Comment 7
2020-01-21 09:50:34 PST
(In reply to Sihui Liu from
comment #6
)
> It's not dead... My change was about the prewarm message. By creating > localStorage ahead, web process connects to the storage area in network > process, and network process does the prewarm there.
Ok, I will revert but add a comment then. It is too subtle otherwise.
Chris Dumez
Comment 8
2020-01-21 09:53:01 PST
Reverted
r254753
for reason: It turns out this is not dead code Committed
r254857
: <
https://trac.webkit.org/changeset/254857
>
Chris Dumez
Comment 9
2020-01-21 09:56:24 PST
<
https://trac.webkit.org/changeset/254858
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug