Bug 206416 – [GTK][WPE][Fetch API] Stale-while-revalidate is not enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Diego Pino]

The following WPT fetch tests are failing since imported:

  * imported/w3c/web-platform-tests/fetch/stale-while-revalidate/fetch-sw.https.html [ Failure ]
  * imported/w3c/web-platform-tests/fetch/stale-while-revalidate/fetch.html [ Failure ] 
  * imported/w3c/web-platform-tests/fetch/stale-while-revalidate/stale-css.html [ Failure ]
  * imported/w3c/web-platform-tests/fetch/stale-while-revalidate/stale-image.html [ Failure ]
  * imported/w3c/web-platform-tests/fetch/stale-while-revalidate/stale-script.html [ Failure ] 

Other two tests, imported earlier, are also failing:

  * imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker.html [ Failure ]

Unskipped in r252363, has been failing since then.

  * imported/w3c/web-platform-tests/fetch/range/sw.https.window.html [ Failure ]

r251594 updated the test and then started to fail. That changeset was later rolled out in r251710, but enabled again in r252047.

[Rob Buis]

Created attachment 388672 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 388672 [details]
Patch

Rejecting attachment 388672 [details] from commit-queue.

New failing tests:
editing/spelling/spellcheck-async-remove-frame.html
Full output: https://webkit-queues.webkit.org/results/13311067

[WebKit Commit Bot]

Created attachment 388703 [details]
Archive of layout-test-results from webkit-cq-03 for mac-mojave

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-mojave  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Comment on attachment 388672 [details]
Patch

Clearing flags on attachment: 388672

Committed r255078: <https://trac.webkit.org/changeset/255078>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Carlos Alberto Lopez Perez]

Re-opening and re-titling to make more clear why this tests fail: Stale-while-revalidate is not enabled for GTK/WPE

[Rob Buis]

Created attachment 397944 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 397944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397944&action=review

> LayoutTests/platform/wpe/TestExpectations:-472
> -# Stale-while-revalidate is not enabled for WPE
> -webkit.org/b/206416 imported/w3c/web-platform-tests/fetch/stale-while-revalidate [ Skip ]

I don't see this patch enabling the feature for WPE at Source/cmake/OptionsWPE.cmake
It seems ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION its also not enabled for WPE, not sure if needed.
And note that the GTK and WPE EWS don't run layout tests, only test to build. Someone has to manually verify that this tests now pass after enabling the feature

[Rob Buis]

Created attachment 397957 [details]
Patch

[Rob Buis]

Comment on attachment 397944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397944&action=review

>> LayoutTests/platform/wpe/TestExpectations:-472
>> -webkit.org/b/206416 imported/w3c/web-platform-tests/fetch/stale-while-revalidate [ Skip ]
> 
> I don't see this patch enabling the feature for WPE at Source/cmake/OptionsWPE.cmake
> It seems ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION its also not enabled for WPE, not sure if needed.
> And note that the GTK and WPE EWS don't run layout tests, only test to build. Someone has to manually verify that this tests now pass after enabling the feature

Right, I was confused because I did not see ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION enabled for WPE, however the s-w-r should be independent with its own build flag, so I now added it. I verified locally GTK layout tests work, however I do not usually build WPE. Are you willing to build it and run the s-w-r tests?

[Carlos Alberto Lopez Perez]

(In reply to Rob Buis from comment #10)
> Are you willing to build it and run the s-w-r tests?

Tested. The 6 tests pass here.

[Carlos Alberto Lopez Perez]

(In reply to Rob Buis from comment #10)
> Right, I was confused because I did not see
> ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION enabled for WPE

I guess nobody cared to enable it for WPE so far.
Any reason to not enable it for WPE? If it works for GTK, it should work also for WPE. Both ports share the same network stack

[Rob Buis]

(In reply to Carlos Alberto Lopez Perez from comment #12)
> (In reply to Rob Buis from comment #10)
> > Right, I was confused because I did not see
> > ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION enabled for WPE
> 
> I guess nobody cared to enable it for WPE so far.
> Any reason to not enable it for WPE? If it works for GTK, it should work
> also for WPE. Both ports share the same network stack

I can't think of any reason not to enable it for WPE.

[EWS]

Committed r261161: <https://trac.webkit.org/changeset/261161>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397957 [details].