Bug 20639 - ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
Summary: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-03 22:33 PDT by Eric Seidel (no email)
Modified: 2008-09-04 14:44 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-09-03 22:33:24 PDT 
ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE

I made i one as part of various Platform.h cleanup in:
http://trac.webkit.org/changeset/36074

Mark fixed it to actually work in:
http://trac.webkit.org/changeset/36076
http://trac.webkit.org/changeset/36078

It doesn't need to be a FEATURE_DEFINE, since it only works for Mac.  it can still be a separate ifdef though, but Platform.h can just turn it on for Apple-Mac only (once we have a way to distinguish Apple's Mac port from any other Mac port).
Comment 1 Mark Rowe (bdash) 2008-09-03 23:15:04 PDT 
After r36074 we have ENABLE_DASHBOARD_SUPPORT sprinkled over many files.  It's not a "feature" like the other items listed in FEATURE_DEFINES, so it should be removed from there ASAP.
Comment 2 Mark Rowe (bdash) 2008-09-04 14:44:40 PDT 
Fixed in r36102.