Bug 206384 - Use the same AccessibilityObjectWrapper for associated AXObject and AXIsolatedObject.
Summary: Use the same AccessibilityObjectWrapper for associated AXObject and AXIsolate...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-16 16:22 PST by Andres Gonzalez
Modified: 2020-01-23 17:49 PST (History)
15 users (show)

See Also:

Attachments
Patch (253.39 KB, patch)
2020-01-16 17:01 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Uploading diff manually. (29.79 KB, patch)
2020-01-16 17:48 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (219.33 KB, patch)
2020-01-23 09:41 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (219.40 KB, patch)
2020-01-23 11:55 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (219.54 KB, patch)
2020-01-23 16:58 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-01-16 16:22:20 PST 
Use the same AccessibilityObjectWrapper for associated AXObject and AXIsolatedObject.
Comment 1 Andres Gonzalez 2020-01-16 17:01:46 PST 
Created attachment 387992 [details]
Patch
Comment 2 Andres Gonzalez 2020-01-16 17:48:04 PST 
Created attachment 387997 [details]
Uploading diff manually.
Comment 3 Andres Gonzalez 2020-01-23 09:41:22 PST 
Created attachment 388555 [details]
Patch
Comment 4 chris fleizach 2020-01-23 09:50:32 PST 
Comment on attachment 388555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388555&action=review

> Source/WebCore/accessibility/AXObjectCache.h:176
> +    void cacheAndInitializeWrapper(AccessibilityObject*, RenderObject* = nullptr, Node* = nullptr, Widget* = nullptr);

don't know if this feasible, but would it be possible to templatize the "other" object (RenderObject/Node/Widget) so that there was only one parameter?

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:354
> +    if (!isMainThread())

should we add something like

if (!clientSupportsIsolatedTree())
   ASSERT_NOT_REACHED()
Comment 5 Andres Gonzalez 2020-01-23 11:55:56 PST 
Created attachment 388571 [details]
Patch
Comment 6 Andres Gonzalez 2020-01-23 16:58:35 PST 
Created attachment 388620 [details]
Patch
Comment 7 WebKit Commit Bot 2020-01-23 17:48:36 PST 
Comment on attachment 388620 [details]
Patch

Clearing flags on attachment: 388620

Committed r255044: <https://trac.webkit.org/changeset/255044>
Comment 8 WebKit Commit Bot 2020-01-23 17:48:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-01-23 17:49:14 PST 
<rdar://problem/58855851>