RESOLVED FIXED206372
[LFC][IFC] Optimize LineLayoutContext::tryAddingInlineItems for the most common inline content 
https://bugs.webkit.org/show_bug.cgi?id=206372
Summary [LFC][IFC] Optimize LineLayoutContext::tryAddingInlineItems for the most comm...
alan
Reported 2020-01-16 14:15:31 PST
ssia
Attachments
Patch (7.76 KB, patch)
2020-01-16 14:17 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.74 KB, patch)
2020-01-16 19:04 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-16 14:15:47 PST
<rdar://problem/58657525>
alan
Comment 2 2020-01-16 14:17:56 PST
Created attachment 387958 [details] Patch
Simon Fraser (smfr)
Comment 3 2020-01-16 14:21:58 PST
Comment on attachment 387958 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387958&action=review > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:209 > +inline void LineCandidateContent::reset() Does the inlining actually make a difference?
alan
Comment 4 2020-01-16 15:56:16 PST
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 387958 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387958&action=review > > > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:209 > > +inline void LineCandidateContent::reset() > > Does the inlining actually make a difference? yes, this is a very hot codepath (I wouldn't have made this change otherwise)
alan
Comment 5 2020-01-16 19:04:05 PST
Created attachment 388002 [details] Patch
WebKit Commit Bot
Comment 6 2020-01-16 20:52:10 PST
Comment on attachment 388002 [details] Patch Clearing flags on attachment: 388002 Committed r254736: <https://trac.webkit.org/changeset/254736>
WebKit Commit Bot
Comment 7 2020-01-16 20:52:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.