Bug 206353 - [GTK][WPE] Composition underline color is not applied
Summary: [GTK][WPE] Composition underline color is not applied
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2020-01-16 06:40 PST by Carlos Garcia Campos
Modified: 2020-01-17 06:00 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2020-01-17 01:40 PST, Carlos Garcia Campos 		svillar: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-01-16 06:40:49 PST 
The right color is received by InlineTextBox::paintCompositionUnderline(), but for some reason colorByApplyingColorFilter() always returns a null color for any given color.
Comment 1 Carlos Garcia Campos 2020-01-17 01:38:14 PST 
The problem was not colorByApplyingColorFilter(), I assumed that was called with the given color, but that's not the case because underline.compositionUnderlineColor is always CompositionUnderlineColor::TextColor. This is because compositionUnderlineColor is not encoded/decoded in the IPC messages.
Comment 2 Carlos Garcia Campos 2020-01-17 01:40:22 PST 
Created attachment 388023 [details]
Patch
Comment 3 Sergio Villar Senin 2020-01-17 02:22:03 PST 
Comment on attachment 388023 [details]
Patch

Don't we have tests for this?
Comment 4 Carlos Garcia Campos 2020-01-17 02:55:07 PST 
Unit tests, but it's not easy to test that the color passed from the API is the actual color of the underline when composing.
Comment 5 Carlos Garcia Campos 2020-01-17 06:00:49 PST 
Committed r254742: <https://trac.webkit.org/changeset/254742>