Bug 206346 - [LFC][IFC] TextUtil::width should use StringView for substrings
Summary: [LFC][IFC] TextUtil::width should use StringView for substrings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-16 04:31 PST by Antti Koivisto
Modified: 2020-01-16 07:39 PST (History)
5 users (show)

See Also:


Attachments
patch (1.62 KB, patch)
2020-01-16 04:39 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-01-16 04:31:15 PST
Instead of creating temporary Strings.
Comment 1 Antti Koivisto 2020-01-16 04:39:34 PST
Created attachment 387909 [details]
patch
Comment 2 WebKit Commit Bot 2020-01-16 07:38:08 PST
The commit-queue encountered the following flaky tests while processing attachment 387909 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2020-01-16 07:38:40 PST
Comment on attachment 387909 [details]
patch

Clearing flags on attachment: 387909

Committed r254679: <https://trac.webkit.org/changeset/254679>
Comment 4 WebKit Commit Bot 2020-01-16 07:38:41 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-01-16 07:39:18 PST
<rdar://problem/58643875>