RESOLVED FIXED 206340
Rename SelectionData classes and structures HighlightData, etc to be more inclusive for their new use cases 
https://bugs.webkit.org/show_bug.cgi?id=206340
Summary Rename SelectionData classes and structures HighlightData, etc to be more inc...
Megan Gardner
Reported 2020-01-16 01:26:16 PST
Rename SelectionData classes and structures HighlightData, etc to be more inclusive for their new use cases
Attachments
Patch (119.12 KB, patch)
2020-01-16 01:31 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (119.92 KB, patch)
2020-01-16 08:22 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (122.52 KB, patch)
2020-01-22 14:28 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (122.12 KB, patch)
2020-02-10 10:35 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-01-16 01:31:19 PST
Created attachment 387898 [details] Patch
Megan Gardner
Comment 2 2020-01-16 08:22:45 PST
Created attachment 387923 [details] Patch
Ryosuke Niwa
Comment 3 2020-01-16 16:42:52 PST
Comment on attachment 387923 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387923&action=review r=me provided the following issues are addressed. > Source/WebCore/rendering/HighlightData.cpp:48 > +struct SelectionData { I guess you're gonna rename this in a followup? > Source/WebCore/rendering/RenderObject.h:696 > + enum HighlightState { Please use enum class instead. We then don't have to prefix every value with "Highlight". Also specify the width: uint8_t. > WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:60 > - BuildableName = "libANGLE-shared.dylib" > + BuildableName = "libANGLE.a" revert?
Megan Gardner
Comment 4 2020-01-22 14:28:47 PST
Created attachment 388470 [details] Patch
Ryosuke Niwa
Comment 5 2020-01-27 16:00:19 PST
Is this new patch still up for a review??
Megan Gardner
Comment 6 2020-01-27 16:55:53 PST
I guess I hadn't actually pushed it, I was going to, but my connection to my work computer stopped functioning and completely distracted me. Did you have more comments?
Megan Gardner
Comment 7 2020-02-10 10:35:23 PST
Created attachment 390261 [details] Patch for landing
WebKit Commit Bot
Comment 8 2020-02-10 11:31:35 PST
The commit-queue encountered the following flaky tests while processing attachment 390261 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2020-02-10 11:32:24 PST
Comment on attachment 390261 [details] Patch for landing Clearing flags on attachment: 390261 Committed r256196: <https://trac.webkit.org/changeset/256196>
WebKit Commit Bot
Comment 10 2020-02-10 11:32:26 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2020-02-10 11:33:23 PST
<rdar://problem/59318985>
Note You need to log in before you can comment on or make changes to this bug.