Bug 206339 - operationToObject() should check for a null errorMessage.
Summary: operationToObject() should check for a null errorMessage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-15 23:31 PST by Mark Lam
Modified: 2020-01-16 09:26 PST (History)
7 users (show)

See Also:


Attachments
proposed patch. (2.57 KB, patch)
2020-01-15 23:35 PST, Mark Lam
ysuzuki: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-01-15 23:31:01 PST
r224280 introduced operationToObject() with an option to specify a custom error message.  r254252 added a scenario where the passed in error message is null but did not fix operationToObject() to allow for this.  We should add the missing null check.

<rdar://problem/58449666>
Comment 1 Mark Lam 2020-01-15 23:35:38 PST
Created attachment 387897 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2020-01-15 23:37:59 PST
Comment on attachment 387897 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2020-01-16 09:26:55 PST
Thanks for the review.  Landed in r254687: <http://trac.webkit.org/r254687>.