Bug 206334 - [LFC] Fix CMake Build
Summary: [LFC] Fix CMake Build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-15 18:47 PST by Don Olmstead
Modified: 2020-01-15 19:51 PST (History)
10 users (show)

See Also:

Attachments
Patch (13.65 KB, patch)
2020-01-15 18:51 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-01-15 18:47:15 PST 
Fix the CMake bits so non-Apple ports can compile.
Comment 1 Don Olmstead 2020-01-15 18:51:41 PST 
Created attachment 387886 [details]
Patch
Comment 2 zalan 2020-01-15 18:55:34 PST 
Comment on attachment 387886 [details]
Patch

Thanks for fixing it!
Comment 3 Don Olmstead 2020-01-15 18:57:09 PST 
(In reply to zalan from comment #2)
> Comment on attachment 387886 [details]
> Patch
> 
> Thanks for fixing it!

No problem! Will land after EWS comes back.
Comment 4 WebKit Commit Bot 2020-01-15 19:49:55 PST 
The commit-queue encountered the following flaky tests while processing attachment 387886 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-01-15 19:50:35 PST 
Comment on attachment 387886 [details]
Patch

Clearing flags on attachment: 387886

Committed r254666: <https://trac.webkit.org/changeset/254666>
Comment 6 WebKit Commit Bot 2020-01-15 19:50:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-15 19:51:11 PST 
<rdar://problem/58631832>