Bug 206322 – Quote file argument to git check-attr

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Darpinian]

Quote file argument to git check-attr

[James Darpinian]

Created attachment 387860 [details]
Quote file argument

[Alexey Proskuryakov]

Comment on attachment 387860 [details]
Quote file argument

Can a regression test be created for this? I’m not familiar with prepare-ChangeLig tests.

[Jonathan Bedard]

Comment on attachment 387860 [details]
Quote file argument

View in context: https://bugs.webkit.org/attachment.cgi?id=387860&action=review

> Tools/Scripts/prepare-ChangeLog:2140
> +        my $command = GIT . " check-attr $attr -- '$file'";

This appears correct, but I'm also curious what made you look into this in the first place. Did you edit a file with a space in the name?

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 387860 [details]
> Quote file argument
> 
> Can a regression test be created for this? I’m not familiar with
> prepare-ChangeLig tests.

We should be able to, Tools/Scripts/webkitperl/prepare-ChangeLog_unittest...probably run by test-webkitperl.

[James Darpinian]

Created attachment 388898 [details]
Add test

[James Darpinian]

Comment on attachment 387860 [details]
Quote file argument

View in context: https://bugs.webkit.org/attachment.cgi?id=387860&action=review

Added a test.

>> Tools/Scripts/prepare-ChangeLog:2140
>> +        my $command = GIT . " check-attr $attr -- '$file'";
> 
> This appears correct, but I'm also curious what made you look into this in the first place. Did you edit a file with a space in the name?

I was updating a third-party dependency, ANGLE, and there's an upstream file with parentheses in the name. Obviously this is not ideal and I can work to rename the upstream file, but this is also a bug that should be fixed.

[WebKit Commit Bot]

Comment on attachment 388898 [details]
Add test

Clearing flags on attachment: 388898

Committed r255272: <https://trac.webkit.org/changeset/255272>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58966431>

[Darin Adler]

Not to be a jerk about it, but a better fix would work even for the filenames containing a single quote character.