Bug 206311 - Web Inspector: show the device settings menu when Web Inspector's debug mode is enabled
Summary: Web Inspector: show the device settings menu when Web Inspector's debug mode ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-15 13:38 PST by Devin Rousso
Modified: 2020-01-16 17:15 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.41 KB, patch)
2020-01-15 13:41 PST, Devin Rousso 		bburg: review+
Details | Formatted Diff | Diff
Patch (2.41 KB, patch)
2020-01-16 16:39 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-01-15 13:38:57 PST 
.
Comment 1 Devin Rousso 2020-01-15 13:41:40 PST 
Created attachment 387838 [details]
Patch
Comment 2 BJ Burg 2020-01-16 16:37:30 PST 
Comment on attachment 387838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387838&action=review

rs=me, except speling.

> Source/WebInspectorUI/ChangeLog:11
> +        toolbar icon, but it will not reapper when Web Inspector is next opened (to allow for taking

Nit: reappear
Comment 3 Devin Rousso 2020-01-16 16:39:02 PST 
Created attachment 387983 [details]
Patch
Comment 4 WebKit Commit Bot 2020-01-16 17:14:13 PST 
The commit-queue encountered the following flaky tests while processing attachment 387983 [details]:

imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large.html bug 201849
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-01-16 17:14:44 PST 
Comment on attachment 387983 [details]
Patch

Clearing flags on attachment: 387983

Committed r254727: <https://trac.webkit.org/changeset/254727>
Comment 6 WebKit Commit Bot 2020-01-16 17:14:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-16 17:15:12 PST 
<rdar://problem/58665014>