WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 206308
Add Web Inspector Reference notice to Web Inspector blog posts
https://bugs.webkit.org/show_bug.cgi?id=206308
Summary
Add Web Inspector Reference notice to Web Inspector blog posts
Jon Davis
Reported
2020-01-15 12:34:44 PST
Created
attachment 387822
[details]
Notice that links to Web Inspector Reference pages Encourage readers to learn more in the Web Inspector Reference pages.
Attachments
Notice that links to Web Inspector Reference pages
(15.35 KB, image/png)
2020-01-15 12:34 PST
,
Jon Davis
no flags
Details
Patch
(1.71 KB, patch)
2020-01-15 12:37 PST
,
Jon Davis
no flags
Details
Formatted Diff
Diff
Patch
(1.71 KB, patch)
2020-01-15 13:13 PST
,
Jon Davis
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jon Davis
Comment 1
2020-01-15 12:37:37 PST
Created
attachment 387823
[details]
Patch
Devin Rousso
Comment 2
2020-01-15 12:43:19 PST
Comment on
attachment 387823
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=387823&action=review
r=me
> Websites/webkit.org/wp-content/themes/webkit/functions.php:149 > + $note = '<div class="note">Note: Learn more about Web Inspector from the <a href="/web-inspector">Web Inspector Reference</a> documentation.</div>';
NIT: shouldn't this be `/web-inspector/`?
Jon Davis
Comment 3
2020-01-15 13:13:36 PST
Created
attachment 387830
[details]
Patch
EWS
Comment 4
2020-01-15 13:15:58 PST
Comment on
attachment 387830
[details]
Patch Rejecting
attachment 387830
[details]
from review queue.
jond@apple.com
does not have reviewer permissions according to
https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json
. - If you do not have reviewer rights please read
http://webkit.org/coding/contributing.html
for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
WebKit Commit Bot
Comment 5
2020-01-15 14:23:36 PST
Comment on
attachment 387830
[details]
Patch Clearing flags on attachment: 387830 Committed
r254639
: <
https://trac.webkit.org/changeset/254639
>
WebKit Commit Bot
Comment 6
2020-01-15 14:23:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2020-01-15 14:24:15 PST
<
rdar://problem/58619223
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug