Bug 206305 – [LFC][IFC] LineBreaker::shouldWrapInlineContent should take the candidate content width

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

No need to re-collect the width.

[Radar WebKit Bug Importer]

<rdar://problem/58613977>

[zalan]

Created attachment 387816 [details]
Patch

[Antti Koivisto]

Comment on attachment 387816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387816&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:138
>  #if USE_FLOAT_AS_INLINE_LAYOUT_UNIT
>      // Preferred width computation sums up floats while line breaker substracts them. This can lead to epsilon-scale differences.

I think this test should move too.

[zalan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 387816 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387816&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp:138
> >  #if USE_FLOAT_AS_INLINE_LAYOUT_UNIT
> >      // Preferred width computation sums up floats while line breaker substracts them. This can lead to epsilon-scale differences.
> 
> I think this test should move too.
Oh right! good catch

[zalan]

Created attachment 387817 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 387817 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 387817 [details]:

media/track/track-in-band-metadata-display-order.html bug 206226 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 387817 [details]
Patch

Rejecting attachment 387817 [details] from commit-queue.

New failing tests:
imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-016.html
imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-009.html
fast/selectors/text-field-selection-stroke-color.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-007.html
fast/forms/negativeLineHeight-simple-lines.html
imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-before-first-char-002.html
fast/text/break-word.html
fast/forms/textarea-placeholder-wrapping.html
imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-003.html
imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-008.html
fast/forms/basic-textareas-quirks-simple-lines.html
fast/forms/linebox-overflow-in-textarea-padding-simple-lines.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-006.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-008.html
fast/text/word-break.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-005.html
fast/text/simple-line-layout-wrapping-multiple-renderers-hang.html
fast/selectors/text-field-selection-window-inactive-stroke-color.html
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-004.html
imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-004.html
Full output: https://webkit-queues.webkit.org/results/13305038

[WebKit Commit Bot]

Created attachment 387853 [details]
Archive of layout-test-results from webkit-cq-02 for mac-mojave

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-mojave  Platform: Mac OS X 10.14.6

[zalan]

Created attachment 387868 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 387868 [details]
Patch

Clearing flags on attachment: 387868

Committed r254661: <https://trac.webkit.org/changeset/254661>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.