Bug 206303 - REGRESSION (r250655?): [ Mac Debug ] inspector/runtime/promise-native-getter.html is a flaky timeout
Summary: REGRESSION (r250655?): [ Mac Debug ] inspector/runtime/promise-native-getter....
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-15 11:22 PST by Truitt Savell
Modified: 2020-01-20 12:51 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.76 KB, patch)
2020-01-17 14:12 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2020-01-15 11:22:54 PST
inspector/runtime/promise-native-getter.html

Description:
This test is a flaky timeout across Mac Debug. I am able to reproduce this by just running the test in iterations.

History:
https://results.webkit.org/?suite=layout-tests&test=inspector%2Fruntime%2Fpromise-native-getter.html

Diff:
--- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/runtime/promise-native-getter-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/inspector/runtime/promise-native-getter-actual.txt
@@ -1,5 +1,6 @@
-CONSOLE MESSAGE: line 8: unhandledrejection - "test"
-CONSOLE MESSAGE: Unhandled Promise Rejection: test
 CONSOLE MESSAGE: line 20: caught - "test"
-CONSOLE MESSAGE: line 12: rejectionhandled - "test"
-Tests that the injected script only `.then()`s promises if they are returned by native getters.
+#PID UNRESPONSIVE - WebKitTestRunner (pid 2758)
+FAIL: Timed out waiting for notifyDone to be called
+
+#EOF
+#EOF
Comment 1 Radar WebKit Bug Importer 2020-01-15 11:23:13 PST
<rdar://problem/58612520>
Comment 2 Truitt Savell 2020-01-15 11:24:59 PST
This test was introduced in https://trac.webkit.org/changeset/244312/webkit
Comment 3 Alexey Proskuryakov 2020-01-15 22:43:43 PST
This regressed pretty sharply in early October, and actually this test times out more frequently than it passes in debug. Looks like it's due to r250655.
Comment 4 Truitt Savell 2020-01-16 10:31:00 PST
Marked this test as timing out while it is investigated https://trac.webkit.org/changeset/254693/webkit
Comment 5 Devin Rousso 2020-01-17 14:12:14 PST
Created attachment 388088 [details]
Patch
Comment 6 WebKit Commit Bot 2020-01-20 12:51:29 PST
Comment on attachment 388088 [details]
Patch

Clearing flags on attachment: 388088

Committed r254834: <https://trac.webkit.org/changeset/254834>
Comment 7 WebKit Commit Bot 2020-01-20 12:51:30 PST
All reviewed patches have been landed.  Closing bug.