Bug 206299 - [Win] Fix AppleWin build
Summary: [Win] Fix AppleWin build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-15 10:59 PST by Per Arne Vollan
Modified: 2020-01-16 07:57 PST (History)
16 users (show)

See Also:


Attachments
Patch (9.32 KB, patch)
2020-01-15 17:12 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (12.81 KB, patch)
2020-01-15 19:47 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-01-15 10:59:20 PST
Fix compile errors in internal AppleWin build.
Comment 1 Per Arne Vollan 2020-01-15 17:12:20 PST
Created attachment 387872 [details]
Patch
Comment 2 Brent Fulgham 2020-01-15 17:27:38 PST
Comment on attachment 387872 [details]
Patch

Looks good. r=me.
Comment 3 Don Olmstead 2020-01-15 17:33:18 PST
Looks good to me as well just wondering if we want to have the target files in a target directory.
Comment 4 Per Arne Vollan 2020-01-15 19:47:03 PST
Created attachment 387889 [details]
Patch
Comment 5 Per Arne Vollan 2020-01-15 19:47:42 PST
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 387872 [details]
> Patch
> 
> Looks good. r=me.

Thanks for reviewing!
Comment 6 Per Arne Vollan 2020-01-15 19:48:01 PST
(In reply to Don Olmstead from comment #3)
> Looks good to me as well just wondering if we want to have the target files
> in a target directory.

Fixed.

Thanks for reviewing!
Comment 7 Per Arne Vollan 2020-01-15 19:49:02 PST
rdar://problem/58379794
Comment 8 WebKit Commit Bot 2020-01-16 07:57:01 PST
Comment on attachment 387889 [details]
Patch

Clearing flags on attachment: 387889

Committed r254681: <https://trac.webkit.org/changeset/254681>
Comment 9 WebKit Commit Bot 2020-01-16 07:57:04 PST
All reviewed patches have been landed.  Closing bug.