Bug 206272 – Platform.h is out of control Part 4: Split PLATFORM_* macro definitions out of Platform.h and into a new PlatformLegacy.h

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Platform.h is out of control Part 4: Split PLATFORM_* macro definitions out of Platform.h and into a new PlatformLegacy.h

[Sam Weinig]

Created attachment 387745 [details]
Patch

[Sam Weinig]

Committed r254572: <https://trac.webkit.org/changeset/254572>

[Radar WebKit Bug Importer]

<rdar://problem/58608497>

[Saam Barati]

Comment on attachment 387745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387745&action=review

> Source/WTF/ChangeLog:8
> +        As a another step towards cleaning up Platform.h, split out all the legacy platform

What makes these legacy?

[Sam Weinig]

(In reply to Saam Barati from comment #4)
> Comment on attachment 387745 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387745&action=review
> 
> > Source/WTF/ChangeLog:8
> > +        As a another step towards cleaning up Platform.h, split out all the legacy platform
> 
> What makes these legacy?

There has been a long stated though poorly communicated goal of phasing out the use of PLATFORM() macros in favor of the more targeted ones. The comment above the definition has read for quite a while:

/* ==== PLATFORM handles OS, operating environment, graphics API, and
   CPU. This macro will be phased out in favor of platform adaptation
   macros, policy decision macros, and top-level port definitions. ==== */