Bug 206268 - REGRESSION (r253394): After swiping back during a navigation, WKWebView gets stuck with the forward content, stops repainting
Summary: REGRESSION (r253394): After swiping back during a navigation, WKWebView gets ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-14 17:03 PST by Tim Horton
Modified: 2020-01-14 18:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.56 KB, patch)
2020-01-14 17:12 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-01-14 17:03:37 PST 
REGRESSION (r253394): After swiping back during a navigation, WKWebView gets stuck with the forward content, stops repainting
Comment 1 Tim Horton 2020-01-14 17:12:46 PST 
Created attachment 387736 [details]
Patch
Comment 2 Tim Horton 2020-01-14 17:12:54 PST 
<rdar://problem/58536702>
Comment 3 Simon Fraser (smfr) 2020-01-14 17:39:02 PST 
Comment on attachment 387736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387736&action=review

> Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm:262
>      m_didCallWillEndSwipeGesture = false;
> +    m_didCallEndSwipeGesture = false;
> +    m_removeSnapshotImmediatelyWhenGestureEnds = false;

Starting to feel like a state machine.
Comment 4 Tim Horton 2020-01-14 17:41:10 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 387736 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387736&action=review
> 
> > Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm:262
> >      m_didCallWillEndSwipeGesture = false;
> > +    m_didCallEndSwipeGesture = false;
> > +    m_removeSnapshotImmediatelyWhenGestureEnds = false;
> 
> Starting to feel like a state machine.

STARTING!?
Comment 5 WebKit Commit Bot 2020-01-14 18:03:41 PST 
Comment on attachment 387736 [details]
Patch

Clearing flags on attachment: 387736

Committed r254552: <https://trac.webkit.org/changeset/254552>
Comment 6 WebKit Commit Bot 2020-01-14 18:03:43 PST 
All reviewed patches have been landed.  Closing bug.