Bug 206251 – AX: Implement support for ARIA 1.3 roles mark, suggestion (ARIA Annotations)

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Aaron Leventhal]

ARIA 1.3 has added these roles to support ARIA annotations.

In addition, mark provides role parity with <mark>.

[Radar WebKit Bug Importer]

<rdar://problem/58577388>

[James Craig]

Aaron requested public comment. I can confirm that Apple Accessibility Engineering has no concern with the ARIA Annotations proposal and intends to implement the mark role. I can't promise a specific date though.

[Joshua Hoffman]

Created attachment 461902 [details]
Patch

[chris fleizach]

Comment on attachment 461902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461902&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2835
> +    return Accessibility::findAncestor(*self.axBackingObject, false, [] (const auto& object) {

ancestorWithRole

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:2031
> +        { "isMark", getIsMarkAnnotationCallback, 0 , kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },

maybe call isMarkAnnotation since that what the rest of the methods call it

[Joshua Hoffman]

Created attachment 461906 [details]
Patch

[Joshua Hoffman]

Created attachment 461986 [details]
Patch

[Joshua Hoffman]

Created attachment 462010 [details]
Patch

[Joshua Hoffman]

Created attachment 462016 [details]
Patch

[Andres Gonzalez]

(In reply to Joshua Hoffman from comment #8)
> Created attachment 462016 [details]
> Patch

--- a/LayoutTests/accessibility/mac/mark-role.html
+++ a/LayoutTests/accessibility/mac/mark-role.html

Shouldn't we also test the role in addition to the attributed string?

[Andres Gonzalez]

(In reply to Andres Gonzalez from comment #9)
> (In reply to Joshua Hoffman from comment #8)
> > Created attachment 462016 [details]
> > Patch
> 
> --- a/LayoutTests/accessibility/mac/mark-role.html
> +++ a/LayoutTests/accessibility/mac/mark-role.html
> 
> Shouldn't we also test the role in addition to the attributed string?

Ah I see, you are doing it in roles-computedRoleString.html.

[EWS]

Committed 254008@main (335a5587c312): <https://commits.webkit.org/254008@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462016 [details].