Bug 20624 - WebKit-gtk uses deprecated GtkType/GtkObject
Summary: WebKit-gtk uses deprecated GtkType/GtkObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-03 05:24 PDT by Chris Lord
Modified: 2008-10-05 18:43 PDT (History)
1 user (show)

See Also:


Attachments
Patch to remove deprecated Gtk types/functions in webkit-gtk (1.71 KB, patch)
2008-09-03 05:25 PDT, Chris Lord
no flags Details | Formatted Diff | Diff
Patch to remove deprecated Gtk types/functions in webkit-gtk (1.78 KB, patch)
2008-09-03 08:22 PDT, Chris Lord
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2008-09-03 05:24:50 PDT
The plugin widget in webkit-gtk uses GtkType instead of GType. The means it fails to build with GTK without deprecated functions enabled (and will fail to build when these functions are removed). The attached patch fixes that (and works fine, in my testing).
Comment 1 Chris Lord 2008-09-03 05:25:51 PDT
Created attachment 23138 [details]
Patch to remove deprecated Gtk types/functions in webkit-gtk
Comment 2 Chris Lord 2008-09-03 08:22:19 PDT
Created attachment 23142 [details]
Patch to remove deprecated Gtk types/functions in webkit-gtk

Fixed coding style (hopefully).
Comment 3 Christian Dywan 2008-09-10 03:54:53 PDT
(In reply to comment #2)
> Created an attachment (id=23142) [edit]
> Patch to remove deprecated Gtk types/functions in webkit-gtk
> 
> Fixed coding style (hopefully).

While you are at it, can't we use G_DEFINE_TYPE?

Btw you should mark patches with a ? if you want them to be reviewed.
Comment 4 Jan Alonzo 2008-10-05 04:28:32 PDT
Comment on attachment 23142 [details]
Patch to remove deprecated Gtk types/functions in webkit-gtk

setting patch for review...
Comment 5 Alp Toker 2008-10-05 16:09:44 PDT
Comment on attachment 23142 [details]
Patch to remove deprecated Gtk types/functions in webkit-gtk

r=me (assuming you checked and it doesn't break Xt plugins)

Cheers
Comment 6 Jan Alonzo 2008-10-05 18:43:38 PDT
Thanks guys. Landed in r37322