Bug 206238 – [WTF] Remove MediaTime.cpp test warning in GCC

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Alicia Boya García]

GCC emits warnings when it finds clang pragmas, so I'm wrapping them
in #ifdef __clang__ to reduce the noise.

[Alicia Boya García]

Created attachment 387662 [details]
Patch

[Charlie Turner]

I think the macros in Compiler.h (IGNORE_*) should be used/modified for these sorts of checks, they have logic to check for compiler support and probably other gotchas.

[Alicia Boya García]

(In reply to Charlie Turner from comment #2)
> I think the macros in Compiler.h (IGNORE_*) should be used/modified for
> these sorts of checks, they have logic to check for compiler support and
> probably other gotchas.

Thing is, these macros are made to ignore warnings in certain compilers. This code on the other hand is intended to turn a specific, disabled by default warning, into an error in clang. This specific warning is also only supported by clang.

And since that code uses clang pragmas, GCC shows a warning, which now I'm trying to avoid.

From a glance at Compiler.h I don't see how they could be used for this case.

I could use `#if COMPILER(clang)` instead of `#ifdef __clang__` though.

[Alicia Boya García]

Created attachment 387671 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 387671 [details]
Patch

Clearing flags on attachment: 387671

Committed r254563: <https://trac.webkit.org/changeset/254563>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58601295>