Bug 206188 - Remove calls to testRunner.installStatisticsDidModifyDataRecordsCallback() in http/tests/resourceLoadStatistics/classify-as-non-prevalent-based-on-sub-frame-under-top-frame-origins*
Summary: Remove calls to testRunner.installStatisticsDidModifyDataRecordsCallback() in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-13 12:59 PST by John Wilander
Modified: 2020-01-13 19:15 PST (History)
2 users (show)

See Also:

Attachments
Patch for landing (3.05 KB, patch)
2020-01-13 13:19 PST, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2020-01-13 12:59:43 PST 
We should not call both testRunner.installStatisticsDidScanDataRecordsCallback() and testRunner.installStatisticsDidModifyDataRecordsCallback().
Comment 1 Radar WebKit Bug Importer 2020-01-13 13:00:02 PST 
<rdar://problem/58540033>
Comment 2 John Wilander 2020-01-13 13:19:46 PST 
Created attachment 387563 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2020-01-13 19:15:14 PST 
The commit-queue encountered the following flaky tests while processing attachment 387563 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2020-01-13 19:15:41 PST 
Comment on attachment 387563 [details]
Patch for landing

Clearing flags on attachment: 387563

Committed r254482: <https://trac.webkit.org/changeset/254482>
Comment 5 WebKit Commit Bot 2020-01-13 19:15:42 PST 
All reviewed patches have been landed.  Closing bug.