Bug 206173 - [Web Animations] Make Animation.timeline read-write only if a runtime flag is enabled
Summary: [Web Animations] Make Animation.timeline read-write only if a runtime flag is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on: 206836
Blocks:
  Show dependency treegraph
 
Reported: 2020-01-13 06:08 PST by Antoine Quint
Modified: 2022-02-10 16:36 PST (History)
10 users (show)

See Also:


Attachments
Patch (16.31 KB, patch)
2020-01-27 22:59 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (18.67 KB, patch)
2020-01-28 01:35 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-01-13 06:08:52 PST
There are still some issues to iron out with Animation.timeline being a read-write property, so we should follow what Firefox and Chrome do and make it read-only alone for now.
Comment 1 Antoine Quint 2020-01-13 06:09:41 PST
Cc'ing Chris Dumez and Sam Weinig for guidance about how to make a property read-only by default and read-write only if a given runtime flag is enabled. I don't think our code generator supports this at the moment.
Comment 2 Radar WebKit Bug Importer 2020-01-13 06:09:57 PST
<rdar://problem/58527432>
Comment 3 Antoine Quint 2020-01-27 22:59:20 PST
Created attachment 388971 [details]
Patch
Comment 4 Antoine Quint 2020-01-28 01:35:21 PST
Created attachment 388976 [details]
Patch
Comment 5 Antoine Quint 2020-01-28 05:38:32 PST
Committed r255234: <https://trac.webkit.org/changeset/255234>