Bug 206172 – Split AudioTrackPrivateMediaStreamCocoa to implement remote audio rendering

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Split AudioTrackPrivateMediaStreamCocoa to implement remote audio rendering

[youenn fablet]

Created attachment 387515 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/58526733>

[youenn fablet]

Created attachment 387516 [details]
Patch

[Eric Carlson]

Comment on attachment 387515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387515&action=review

> Source/WebCore/ChangeLog:9
> +        For that purpose, splut AudioTrackPrivateMediaStreamCocoa functionality in two parts.

s/splut/split/

> Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.cpp:111
> +// May get called on a background thread.

Should we protect access to the renderer with a lock so, e.g., problems when clear() and audioSamplesAvailable() are called concurrently?

> Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.h:77
> +    AtomString language() const final { return emptyAtom(); }

This override isn't necessary as the base class already returns emptyAtom();

[youenn fablet]

(In reply to Eric Carlson from comment #4)
> Comment on attachment 387515 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387515&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        For that purpose, splut AudioTrackPrivateMediaStreamCocoa functionality in two parts.
> 
> s/splut/split/

OK

> > Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.cpp:111
> > +// May get called on a background thread.
> 
> Should we protect access to the renderer with a lock so, e.g., problems when
> clear() and audioSamplesAvailable() are called concurrently?

We should be good now and the old code making a protectedThis is a left over.
Reason is that we should call clear() before entering the destructor.

> > Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.h:77
> > +    AtomString language() const final { return emptyAtom(); }
> 
> This override isn't necessary as the base class already returns emptyAtom();

OK

[youenn fablet]

Created attachment 387519 [details]
Patch

[youenn fablet]

Created attachment 387521 [details]
Patch

[youenn fablet]

Created attachment 387524 [details]
Patch

[youenn fablet]

Created attachment 387526 [details]
Patch

[youenn fablet]

Created attachment 387529 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 387529 [details]
Patch

Clearing flags on attachment: 387529

Committed r254446: <https://trac.webkit.org/changeset/254446>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.