Bug 206170 – onwebkit{animation, transition}XX handlers missing from Document

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Stephen McGruer]

Created attachment 387514 [details]
Reproduction of bug

The spec says[0] that the prefixed animation event handlers (listed below) are defined on 'elements, Document objects, and Window objects'. Firefox defines it on all three, Chrome currently defines them only on Window but this is being fixed in [1], and WebKit defines them on elements and Window objects but not HTMLElements.

The event handlers are:

  * onwebkitanimationend
  * onwebkitanimationiteration
  * onwebkitanimationstart
  * onwebkittransitionend

A reproduction is attached. There are wpt.fyi tests at wpt/html/dom/idlharness.https.html?include=HTML.*[2] and wpt/html/dom/idlharness.https.html?include=(Document|Window)[3], but it looks like Safari's webdriver implementation fails to handle URLs with '(' (or maybe '|') in them, so currently the tests are harness errors (will file a separate bug for that).

[0]: https://html.spec.whatwg.org/multipage/webappapis.html#event-handlers-on-elements,-document-objects,-and-window-objects
[1]: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/4Fidt4JqkTk
[2]: https://wpt.fyi/results/html/dom/idlharness.https.html%3Finclude=HTML.*?label=experimental&label=master&aligned
[3]: https://wpt.fyi/results/html/dom/idlharness.https.html%3Finclude%3D(Document%7CWindow)?label=master&label=experimental&aligned

[Radar WebKit Bug Importer]

<rdar://problem/58596373>

[Jon Lee]

Is this a regression at all? And does this affect only the prefixed handlers?

[Antoine Quint]

Stephen, I expect you meant "WebKit defines them on elements and Window objects but not Document objects", correct?

[Antoine Quint]

Created attachment 393961 [details]
Patch

[Antoine Quint]

(In reply to Jon Lee from comment #2)
> Is this a regression at all? And does this affect only the prefixed handlers?

Not a regression and yes, it only applies to prefixed handlers as the standard, non-prefixed handlers are defined in GlobalEventHandlers.idl, which is implemented by Document, DOMWindow, HTMLElement and SVGElement.

[Antoine Quint]

Created attachment 393968 [details]
Patch

[Antoine Quint]

For reference, this is the WebDriver bug Stephen is talking about: https://bugs.webkit.org/show_bug.cgi?id=206171.

[EWS]

Committed r258697: <https://trac.webkit.org/changeset/258697>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 393968 [details].