Bug 206165 - [LFC][Integration] Build and enable on Windows
Summary: [LFC][Integration] Build and enable on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-13 02:28 PST by Antti Koivisto
Modified: 2020-01-28 13:21 PST (History)
13 users (show)

See Also:

Attachments
Patch (3.36 KB, patch)
2020-01-23 10:39 PST, Don Olmstead 		darin: review+
Details | Formatted Diff | Diff
Patch (2.86 KB, patch)
2020-01-28 11:58 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-01-13 02:28:19 PST 
LFC is not currently building on windows.
Comment 1 Don Olmstead 2020-01-15 11:17:26 PST 
Antti our IRC connection is down otherwise I'd ping you directly. LineBreaker::Run::operator= is missing.
Comment 2 Antti Koivisto 2020-01-15 11:22:13 PST 
I guess VC++ has trouble with vectors and move semantics?
Comment 3 Don Olmstead 2020-01-23 10:39:23 PST 
Created attachment 388561 [details]
Patch
Comment 4 Don Olmstead 2020-01-23 11:52:47 PST 
On IRC anttik mentioned that LFC had been turned off due to perf issues. This patch just enables LFC on WinCairo when experimental features are enabled. So the feature will be ON for developers only. It will also catch any build errors when using MSVC around the feature.

We personally think its fine to land this assuming a r+.
Comment 5 Antti Koivisto 2020-01-27 01:09:01 PST 
We are back to enabled on Mac so this is ok.
Comment 6 Don Olmstead 2020-01-28 11:58:24 PST 
Created attachment 389046 [details]
Patch
Comment 7 WebKit Commit Bot 2020-01-28 13:01:30 PST 
The commit-queue encountered the following flaky tests while processing attachment 389046 [details]:

http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-01-28 13:01:53 PST 
The commit-queue encountered the following flaky tests while processing attachment 389046 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2020-01-28 13:20:31 PST 
Comment on attachment 389046 [details]
Patch

Clearing flags on attachment: 389046

Committed r255273: <https://trac.webkit.org/changeset/255273>
Comment 10 WebKit Commit Bot 2020-01-28 13:20:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2020-01-28 13:21:15 PST 
<rdar://problem/58966926>