Bug 206159 – [EWS] Add unit tests for factories

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Add unit tests for EWS factories.

[Aakash Jain]

Created attachment 387498 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 387498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387498&action=review

> Tools/ChangeLog:3
> +        [EWS] Add unit tests for factories

Will this run as part of an existing test suite on bots?

[Aakash Jain]

(In reply to Alexey Proskuryakov from comment #2)
> Will this run as part of an existing test suite on bots?
Yes, in fact these unit-tests were automatically run by the Services EWS for this patch as well (since runUnittests.py script automatically runs _unittest.py files in that directory).

The corresponding build for this patch run 180 tests (in https://ews-build.webkit.org/#/builders/20/builds/11417/steps/7/logs/stdio), while previously 172 tests were being run (e.g.: https://ews-build.webkit.org/#/builders/20/builds/11092/steps/7/logs/stdio).

[Jonathan Bedard]

Comment on attachment 387498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387498&action=review

>> Tools/ChangeLog:3
>> +        [EWS] Add unit tests for factories
> 
> Will this run as part of an existing test suite on bots?

Yes, Tools/BuildSlaveSupport/ews-build/runUnittests.py will pick it up.

> Tools/BuildSlaveSupport/ews-build/factories_unittest.py:40
> +        actual_steps = map(step_to_dict, actual_steps)

I would expect the style checker to want an empty line here to separate the function

[Aakash Jain]

Created attachment 387561 [details]
Patch

[Aakash Jain]

(In reply to Jonathan Bedard from comment #4)
> I would expect the style checker to want an empty line here to separate the function
Added empty line.

[Aakash Jain]

Committed r254448: <https://trac.webkit.org/changeset/254448>

[Radar WebKit Bug Importer]

<rdar://problem/58541484>