Bug 206156 – [macCatalyst] UI process crashes on launch after r254101

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Wenson Hsieh]

...while attempting to soft link BackBoardServices for display brightness detection.

[Radar WebKit Bug Importer]

<rdar://problem/58514942>

[Wenson Hsieh]

    frame #1: 0x000000010909c00f WebKit`initBKSDisplayBrightnessGetCurrent() at WebProcessPoolCocoa.mm:107:1 [opt]
    frame #2: 0x00000001090f1d3b WebKit`WebKit::WebProcessPool::initializeNewWebProcess(this=<unavailable>, process=0x0000000129be53c0, websiteDataStore=0x0000600000be3848, isPrewarmed=No) at WebProcessPool.cpp:1059:64 [opt]
    frame #3: 0x00000001090f22bd WebKit`WebKit::WebProcessPool::createNewWebProcess(this=0x00007f8d2e0d8008, websiteDataStore=0x0000600000be3848, isPrewarmed=No) at WebProcessPool.cpp:836:5 [opt]
    frame #4: 0x00000001090f3805 WebKit`WebKit::WebProcessPool::processForRegistrableDomain(this=0x00007f8d2e0d8008, websiteDataStore=0x0000600000be3848, page=<unavailable>, registrableDomain=<unavailable>) at WebProcessPool.cpp:0 [opt]
    frame #5: 0x00000001090b3c83 WebKit`WebKit::WebPageProxy::launchProcess(this=0x00007f8d2e0e9620, registrableDomain=0x00007ffee6ea3990, reason=InitialProcess) at WebPageProxy.cpp:766:33 [opt]
    frame #6: 0x00000001090b725f WebKit`WebKit::WebPageProxy::loadRequest(this=0x00007f8d2e0e9620, request=0x00007ffee6ea3b90, shouldOpenExternalURLsPolicy=<unavailable>, userData=<unavailable>) at WebPageProxy.cpp:1245:9 [opt]
    frame #7: 0x000000010901ab1d WebKit`-[WKWebView loadRequest:](self=<unavailable>, _cmd=<unavailable>, request=<unavailable>) at WKWebView.mm:701:27 [opt]

[Wenson Hsieh]

Created attachment 387490 [details]
Patch

[Brent Fulgham]

Comment on attachment 387490 [details]
Patch

R=me

[Wenson Hsieh]

Comment on attachment 387490 [details]
Patch

Thanks for the review!

[WebKit Commit Bot]

Comment on attachment 387490 [details]
Patch

Rejecting attachment 387490 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 387490, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=387490&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=206156&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 387490 from bug 206156.
Fetching: https://bugs.webkit.org/attachment.cgi?id=387490
Authentication required
Authentication required
Authentication required
Updating OpenSource
From https://git.webkit.org/git/WebKit
   f3dea866b43..17265b441d3  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 254431 = f3dea866b435981d60d421826d9a3fbfa0473876
r254432 = 17265b441d342970b25dd93a8c7dc69af9f0b850
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13303501

[Wenson Hsieh]

Comment on attachment 387490 [details]
Patch

Committed r254433: <https://trac.webkit.org/changeset/254433>