Bug 206141 - [WebCore] Reorganize JSType in WebCore to offer more bits to JSC
Summary: [WebCore] Reorganize JSType in WebCore to offer more bits to JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-12 01:55 PST by Yusuke Suzuki
Modified: 2020-01-12 16:03 PST (History)
7 users (show)

See Also:


Attachments
Patch (6.62 KB, patch)
2020-01-12 01:56 PST, Yusuke Suzuki
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-01-12 01:55:35 PST
[WebCore] Reorganize JSType in WebCore to offer more bits to JSC
Comment 1 Yusuke Suzuki 2020-01-12 01:56:12 PST
Created attachment 387464 [details]
Patch
Comment 2 Keith Miller 2020-01-12 11:09:03 PST
Comment on attachment 387464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387464&action=review

r=me. We have 128 types these days?!? O.o

> Source/WebCore/bindings/js/JSDOMWrapper.h:32
>  // JSC allows us to extend JSType. If the highest bit is set, we can add any Object types and they are

Can you fix this comment to match the new rule.
Comment 3 Yusuke Suzuki 2020-01-12 14:41:24 PST
Comment on attachment 387464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387464&action=review

>> Source/WebCore/bindings/js/JSDOMWrapper.h:32
>>  // JSC allows us to extend JSType. If the highest bit is set, we can add any Object types and they are
> 
> Can you fix this comment to match the new rule.

Fixed.
Comment 4 Yusuke Suzuki 2020-01-12 14:42:57 PST
Committed r254416: <https://trac.webkit.org/changeset/254416>
Comment 5 Radar WebKit Bug Importer 2020-01-12 14:43:11 PST
<rdar://problem/58515054>
Comment 6 Mark Lam 2020-01-12 16:03:35 PST
Comment on attachment 387464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387464&action=review

> Source/JavaScriptCore/runtime/JSType.h:140
> +static_assert(LastJSCObjectType < 0b11100000, "Embedder can use 0b11100000 or upper.");

I think you meant to say "above" instead of "upper".