[JSC] Remove IsDone from JSArrayIterator
Created attachment 387461 [details] Patch
Comment on attachment 387461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387461&action=review > Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:-549 > - clone->internalField(JSArrayIterator::Field::IsDone).set(vm, clone, iteratorObject->internalField(JSArrayIterator::Field::IsDone).get()); I think we should still show this in Web Inspector, as it’s useful for developers to know when debugging.
Comment on attachment 387461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387461&action=review The test failures look unrelated. >> Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:-549 >> - clone->internalField(JSArrayIterator::Field::IsDone).set(vm, clone, iteratorObject->internalField(JSArrayIterator::Field::IsDone).get()); > > I think we should still show this in Web Inspector, as it’s useful for developers to know when debugging. You can show in the inspector side by comparing `index === -1`. Currently, inspector is not showing it.
Created attachment 387492 [details] Patch
Comment on attachment 387492 [details] Patch Have you run the microbenchmarks to see if there's a significant difference?
(In reply to Keith Miller from comment #5) > Comment on attachment 387492 [details] > Patch > > Have you run the microbenchmarks to see if there's a significant difference? No difference. This change is basically for JSStringIterator to use the same mechanism to keep sizeof(JSStringIterator) small.
Cool LGTM then
Committed r254419: <https://trac.webkit.org/changeset/254419>
<rdar://problem/58517697>