Bug 206136 - CheckNeutered needs to claim it reads JSType in clobberize.
Summary: CheckNeutered needs to claim it reads JSType in clobberize.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-11 18:00 PST by Keith Miller
Modified: 2020-01-13 09:21 PST (History)
8 users (show)

See Also:


Attachments
Patch (3.21 KB, patch)
2020-01-12 12:12 PST, Keith Miller
ysuzuki: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2020-01-11 18:00:52 PST
CheckNeutered needs to claim it reads JSType in clobberize.
Comment 1 Keith Miller 2020-01-12 12:12:59 PST
Created attachment 387486 [details]
Patch
Comment 2 Yusuke Suzuki 2020-01-12 14:08:29 PST
Comment on attachment 387486 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2020-01-13 08:49:02 PST
The commit-queue encountered the following flaky tests while processing attachment 387486 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2020-01-13 08:49:30 PST
Comment on attachment 387486 [details]
Patch

Rejecting attachment 387486 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 387486, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=387486&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=206136&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 387486 from bug 206136.
Fetching: https://bugs.webkit.org/attachment.cgi?id=387486
Authentication required
Authentication required
Authentication required
Updating OpenSource
From https://git.webkit.org/git/WebKit
   97546802d1f..f3dea866b43  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 254429 = 97546802d1f617aaf6bc0230a7aa3681de1000c5
r254430 = cb8b8045851cc7dcc55df602d77303d59cc1f500
r254431 = f3dea866b435981d60d421826d9a3fbfa0473876
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13303482
Comment 5 Keith Miller 2020-01-13 09:20:05 PST
Committed r254434: <https://trac.webkit.org/changeset/254434>
Comment 6 Radar WebKit Bug Importer 2020-01-13 09:21:15 PST
<rdar://problem/58531221>