Bug 206133 – [LFC][IFC] Visually collapse hanging pre-wrap content.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

"If white-space is set to pre-wrap, the UA must (unconditionally) hang this sequence, unless the sequence is followed by a forced line break, in which case it must conditionally hang the sequence is instead. It ___may___ also visually collapse the character advance widths of any that would otherwise overflow."

[Radar WebKit Bug Importer]

<rdar://problem/58505750>

[alan]

Created attachment 387441 [details]
Patch

[Antti Koivisto]

Comment on attachment 387441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387441&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:237
> +    visuallyCollapsePreWrapOverflowContent();

Shouldn't this depend on alignment somehow?

[alan]

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 387441 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387441&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:237
> > +    visuallyCollapsePreWrapOverflowContent();
> 
> Shouldn't this depend on alignment somehow?
Yup, you are right

[alan]

(In reply to zalan from comment #4)
> (In reply to Antti Koivisto from comment #3)
> > Comment on attachment 387441 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=387441&action=review
> > 
> > > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:237
> > > +    visuallyCollapsePreWrapOverflowContent();
> > 
> > Shouldn't this depend on alignment somehow?
> Yup, you are right
It is actually the other way around. The unconditionally hanging whitespace should be ignored when it comes to horizontal alignment even if it places the trailing whitespace outside of the line box. ->
"As the preserved spaces at the end of lines without a forced break must hang, they are not considered when placing the rest of the line during text alignment. When aligning towards the end, this means any such spaces will overflow, and will not prevent the rest of the line’s content from being flush with the edge of the line."

[alan]

There are some very nice visual examples at https://www.w3.org/TR/css-text-3/#white-space-phase-2

[alan]

SLL seems to be retrofitting the hanging content width.

[alan]

Committed r254402: <https://trac.webkit.org/changeset/254402>