Bug 206124 - Platform.h is out of control Part 1: Split WTF_CPU_* macro definitions out of Platform.h and into a new CPU.h
Summary: Platform.h is out of control Part 1: Split WTF_CPU_* macro definitions out of...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-10 21:34 PST by Sam Weinig
Modified: 2020-01-11 10:08 PST (History)
12 users (show)

See Also:

Attachments
Patch (106.44 KB, patch)
2020-01-10 21:36 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-01-10 21:34:11 PST 
Split WTF_CPU_* macro definitions out of Platform.h and into a new CPU.h
Comment 1 Sam Weinig 2020-01-10 21:36:58 PST 
Created attachment 387421 [details]
Patch
Comment 2 Anders Carlsson 2020-01-11 07:41:07 PST 
Comment on attachment 387421 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387421&action=review

> Source/WTF/wtf/CPU.h:186
> +// FIXME: WTF_THUMB_ARCH_VERSION seems unusued. Remove.

*unusued*.

> Source/WTF/wtf/Platform.h:81
> +/* FIXME: This should be renamed to WTF_CPU_ARM_IDIV_INSTRUCTIONS and moved to CPU.h */

Why use C comments here?
Comment 3 Sam Weinig 2020-01-11 10:07:06 PST 
Committed r254401: <https://trac.webkit.org/changeset/254401>
Comment 4 Sam Weinig 2020-01-11 10:08:01 PST 
(In reply to Anders Carlsson from comment #2)
> Comment on attachment 387421 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387421&action=review
> 
> > Source/WTF/wtf/CPU.h:186
> > +// FIXME: WTF_THUMB_ARCH_VERSION seems unusued. Remove.
> 
> *unusued*.

Fixed.

> 
> > Source/WTF/wtf/Platform.h:81
> > +/* FIXME: This should be renamed to WTF_CPU_ARM_IDIV_INSTRUCTIONS and moved to CPU.h */
> 
> Why use C comments here?

The whole file is supposed to uses C comments so it can be included in C files. I fixed the other one to also be a C comment.

Thanks for the review.
Comment 5 Radar WebKit Bug Importer 2020-01-11 10:08:11 PST 
<rdar://problem/58504848>