Bug 206104 – Expose frame information on _WKResourceLoadInfo

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Expose frame information on _WKResourceLoadInfo

[Alex Christensen]

Created attachment 387387 [details]
Patch

[Alex Christensen]

Created attachment 387390 [details]
Patch

[Alex Christensen]

Created attachment 387398 [details]
Patch

[Dean Jackson]

Comment on attachment 387398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387398&action=review

> Source/WebKit/Shared/API/Cocoa/_WKFrameHandle.mm:93
> +    [coder encodeObject:@([self frameID]) forKey:@"frameID"];

self.frameID ?

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:596
> -    if (page)
> -        loadParameters.pageHasResourceLoadClient = page->hasResourceLoadClient();
> +    addParametersFromFrame(webFrame->coreFrame(), loadParameters);

I assume it is totally ok that the loadParameters here might get .isHTTPSUpgradeEnabled set now, when it didn't before?

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:662
> +    addParametersFromFrame(&frame, loadParameters);

Same here.

[Alex Christensen]

(In reply to Dean Jackson from comment #4)
> I assume it is totally ok that the loadParameters here might get
> .isHTTPSUpgradeEnabled set now, when it didn't before?
Yes, that was an oversight before.  We want https upgrade for sync xhr and beacon.

[Alex Christensen]

http://trac.webkit.org/r254409

[Radar WebKit Bug Importer]

<rdar://problem/58507584>