WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
206084
Add modulemap for WebKit Private APIs (take 2)
https://bugs.webkit.org/show_bug.cgi?id=206084
Summary
Add modulemap for WebKit Private APIs (take 2)
Dean Jackson
Reported
2020-01-10 13:09:34 PST
Add Swift modulemap for WebKit Private APIs (take 2)
Attachments
Patch
(21.08 KB, patch)
2020-01-10 13:14 PST
,
Dean Jackson
no flags
Details
Formatted Diff
Diff
Patch
(20.64 KB, patch)
2020-01-10 13:48 PST
,
Dean Jackson
no flags
Details
Formatted Diff
Diff
Patch
(20.61 KB, patch)
2020-01-10 14:57 PST
,
Dean Jackson
no flags
Details
Formatted Diff
Diff
Patch
(21.32 KB, patch)
2020-01-11 10:06 PST
,
Dean Jackson
no flags
Details
Formatted Diff
Diff
Patch
(21.83 KB, patch)
2020-01-11 11:04 PST
,
Dean Jackson
no flags
Details
Formatted Diff
Diff
Patch
(21.28 KB, patch)
2020-01-11 11:51 PST
,
Dean Jackson
thorton
: review+
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-01-10 13:10:19 PST
<
rdar://problem/58488356
>
Dean Jackson
Comment 2
2020-01-10 13:14:03 PST
Created
attachment 387368
[details]
Patch
Dean Jackson
Comment 3
2020-01-10 13:48:52 PST
Created
attachment 387371
[details]
Patch
Dean Jackson
Comment 4
2020-01-10 14:57:16 PST
Created
attachment 387378
[details]
Patch
Anders Carlsson
Comment 5
2020-01-10 18:09:47 PST
Looks like the builds are broken.
Dean Jackson
Comment 6
2020-01-11 10:06:20 PST
Created
attachment 387435
[details]
Patch
Dean Jackson
Comment 7
2020-01-11 11:04:51 PST
Created
attachment 387437
[details]
Patch
Dean Jackson
Comment 8
2020-01-11 11:51:10 PST
Created
attachment 387439
[details]
Patch
Tim Horton
Comment 9
2020-01-14 15:08:47 PST
Comment on
attachment 387439
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=387439&action=review
> Source/WebKit/Shared/API/Cocoa/WebKitPrivate.h:31 > +#import <WebKit/DOMHTMLMediaElement.h>
I wooooonder if we should not include the WebKitLegacy headers, and tuck them in a TAPI -extra-private-header (aka the way to lie to TAPI). Probably the correct answer is "no" but it feels so much less dirty :(
Dean Jackson
Comment 10
2020-01-17 16:58:03 PST
(In reply to Anders Carlsson from
comment #5
)
> Looks like the builds are broken.
👍
Dean Jackson
Comment 11
2020-01-17 16:58:59 PST
(In reply to Tim Horton from
comment #9
)
> Comment on
attachment 387439
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=387439&action=review
> > > Source/WebKit/Shared/API/Cocoa/WebKitPrivate.h:31 > > +#import <WebKit/DOMHTMLMediaElement.h> > > I wooooonder if we should not include the WebKitLegacy headers, and tuck > them in a TAPI -extra-private-header (aka the way to lie to TAPI). Probably > the correct answer is "no" but it feels so much less dirty :(
I bet that if we do that, some random project will fail to compile, like before. We'd have to search for all the projects that are trying to include those headers wouldn't we?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug