Bug 206050 - [LFC] Replace FormattingContext::EscapeTypes with EscapeReasons
Summary: [LFC] Replace FormattingContext::EscapeTypes with EscapeReasons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-09 18:44 PST by zalan
Modified: 2020-01-10 07:20 PST (History)
6 users (show)

See Also:

Attachments
Patch (22.11 KB, patch)
2020-01-09 18:51 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (24.98 KB, patch)
2020-01-09 21:36 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-01-09 18:44:04 PST 
to be more explicit about why certain escapes are allowed
Comment 1 Radar WebKit Bug Importer 2020-01-09 18:44:23 PST 
<rdar://problem/58466862>
Comment 2 zalan 2020-01-09 18:51:45 PST 
Created attachment 387308 [details]
Patch
Comment 3 zalan 2020-01-09 21:36:44 PST 
Created attachment 387313 [details]
Patch
Comment 4 Antti Koivisto 2020-01-10 02:16:42 PST 
Comment on attachment 387313 [details]
Patch

No escapes allowed for any reason!
Comment 5 WebKit Commit Bot 2020-01-10 07:06:45 PST 
Comment on attachment 387313 [details]
Patch

Clearing flags on attachment: 387313

Committed r254336: <https://trac.webkit.org/changeset/254336>
Comment 6 WebKit Commit Bot 2020-01-10 07:06:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 zalan 2020-01-10 07:20:27 PST 
(In reply to Antti Koivisto from comment #4)
> Comment on attachment 387313 [details]
> Patch
> 
> No escapes allowed for any reason!
Only the good escapes.