Bug 20604 – AnimationController.cpp should be split into separate files

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Marrin]

The file has gotten very large and unweildy. I propose we split it into 5 parts:

    AnimationController
    CompositeAnimation
    AnimationBase
    ImplicitAnimation
    KeyframeAnimation

and put them all into a new subdirectory of page named 'animation'

[Chris Marrin]

Created attachment 23122 [details]
Patch to fix bug

[Dave Hyatt]

Comment on attachment 23122 [details]
Patch to fix bug

The Windows project file changes aren't right.  Each file needs to get its own individual <File> entry.  Look more closely at the file and you'll see what I mean.

[Chris Marrin]

Created attachment 23129 [details]
Second attempt at patch to fix issues in WebCore.vcproj

[Dave Hyatt]

Comment on attachment 23129 [details]
Second attempt at patch to fix issues in WebCore.vcproj

r=me

[Dean Jackson]

Committed r36031
	M	WebCore/GNUmakefile.am
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/WebCore.pro
	M	WebCore/ChangeLog
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/WebCoreSources.bkl
	D	WebCore/page/AnimationController.h
	D	WebCore/page/AnimationController.cpp
	A	WebCore/page/animation/AnimationBase.h
	A	WebCore/page/animation/ImplicitAnimation.h
	A	WebCore/page/animation/CompositeAnimation.cpp
	A	WebCore/page/animation/AnimationController.cpp
	A	WebCore/page/animation/KeyframeAnimation.cpp
	A	WebCore/page/animation/CompositeAnimation.h
	A	WebCore/page/animation/AnimationController.h
	A	WebCore/page/animation/KeyframeAnimation.h
	A	WebCore/page/animation/AnimationBase.cpp
	A	WebCore/page/animation/ImplicitAnimation.cpp