Bug 20604 - AnimationController.cpp should be split into separate files
Summary: AnimationController.cpp should be split into separate files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-02 11:39 PDT by Chris Marrin
Modified: 2008-09-02 18:37 PDT (History)
2 users (show)

See Also:


Attachments
Patch to fix bug (387.29 KB, patch)
2008-09-02 11:52 PDT, Chris Marrin
hyatt: review-
Details | Formatted Diff | Diff
Second attempt at patch to fix issues in WebCore.vcproj (388.27 KB, patch)
2008-09-02 15:26 PDT, Chris Marrin
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2008-09-02 11:39:00 PDT
The file has gotten very large and unweildy. I propose we split it into 5 parts:

    AnimationController
    CompositeAnimation
    AnimationBase
    ImplicitAnimation
    KeyframeAnimation

and put them all into a new subdirectory of page named 'animation'
Comment 1 Chris Marrin 2008-09-02 11:52:09 PDT
Created attachment 23122 [details]
Patch to fix bug
Comment 2 Dave Hyatt 2008-09-02 15:16:29 PDT
Comment on attachment 23122 [details]
Patch to fix bug

The Windows project file changes aren't right.  Each file needs to get its own individual <File> entry.  Look more closely at the file and you'll see what I mean.
Comment 3 Chris Marrin 2008-09-02 15:26:55 PDT
Created attachment 23129 [details]
Second attempt at patch to fix issues in WebCore.vcproj
Comment 4 Dave Hyatt 2008-09-02 15:35:20 PDT
Comment on attachment 23129 [details]
Second attempt at patch to fix issues in WebCore.vcproj

r=me
Comment 5 Dean Jackson 2008-09-02 18:37:52 PDT
Committed r36031
	M	WebCore/GNUmakefile.am
	M	WebCore/WebCore.xcodeproj/project.pbxproj
	M	WebCore/WebCore.pro
	M	WebCore/ChangeLog
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/WebCoreSources.bkl
	D	WebCore/page/AnimationController.h
	D	WebCore/page/AnimationController.cpp
	A	WebCore/page/animation/AnimationBase.h
	A	WebCore/page/animation/ImplicitAnimation.h
	A	WebCore/page/animation/CompositeAnimation.cpp
	A	WebCore/page/animation/AnimationController.cpp
	A	WebCore/page/animation/KeyframeAnimation.cpp
	A	WebCore/page/animation/CompositeAnimation.h
	A	WebCore/page/animation/AnimationController.h
	A	WebCore/page/animation/KeyframeAnimation.h
	A	WebCore/page/animation/AnimationBase.cpp
	A	WebCore/page/animation/ImplicitAnimation.cpp