Bug 206039 - Clean up -[WKWebView _initializeWithConfiguration:]
Summary: Clean up -[WKWebView _initializeWithConfiguration:]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-09 15:06 PST by Simon Fraser (smfr)
Modified: 2020-01-10 11:53 PST (History)
4 users (show)

See Also:


Attachments
Patch (17.64 KB, patch)
2020-01-09 15:07 PST, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff
Patch (17.84 KB, patch)
2020-01-09 15:57 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-01-09 15:06:30 PST
Clean up -[WKWebView _initializeWithConfiguration:]
Comment 1 Simon Fraser (smfr) 2020-01-09 15:07:57 PST
Created attachment 387279 [details]
Patch
Comment 2 Tim Horton 2020-01-09 15:19:47 PST
Comment on attachment 387279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387279&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:170
> +static const BOOL defaultAllowsViewportShrinkToFit = YES;

Shouldn't these be in some WebPreferences* file?
Comment 3 Simon Fraser (smfr) 2020-01-09 15:57:19 PST
Created attachment 387285 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-01-10 11:52:10 PST
https://trac.webkit.org/changeset/254315/webkit
Comment 5 Radar WebKit Bug Importer 2020-01-10 11:53:18 PST
<rdar://problem/58486170>