Bug 206035 - Check the existence of the optional m_sessionID before using it in WebProcess::setResourceLoadStatisticsEnabled()
Summary: Check the existence of the optional m_sessionID before using it in WebProcess...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-09 14:12 PST by John Wilander
Modified: 2020-01-16 15:02 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2020-01-09 14:14 PST, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2020-01-09 14:12:06 PST 
Since m_sessionID is optional, we need to check that it exists before asking it whether the session is ephemeral.
Comment 1 John Wilander 2020-01-09 14:12:20 PST 
<rdar://problem/58455306>
Comment 2 John Wilander 2020-01-09 14:14:42 PST 
Created attachment 387271 [details]
Patch
Comment 3 Brent Fulgham 2020-01-09 15:02:51 PST 
Comment on attachment 387271 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2020-01-09 15:47:42 PST 
Comment on attachment 387271 [details]
Patch

Clearing flags on attachment: 387271

Committed r254310: <https://trac.webkit.org/changeset/254310>
Comment 5 WebKit Commit Bot 2020-01-09 15:47:43 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Jonathan Bedard 2020-01-10 13:46:09 PST 
I'm not 100% sure this is the cause, but we have a flakey regression in a resource load statistics test, and this seems like a plausible candidate:

https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2FresourceLoadStatistics%2Fclassify-as-non-prevalent-based-on-sub-frame-under-top-frame-origins-database.html
Comment 7 Jonathan Bedard 2020-01-10 13:47:23 PST 
Although <https://trac.webkit.org/changeset/254296> is also a plausible candidate.
Comment 8 John Wilander 2020-01-10 15:08:42 PST 
Thanks for flagging, Jonathan! I'm trying to address the flakiness in https://bugs.webkit.org/show_bug.cgi?id=206100.
Comment 9 John Wilander 2020-01-14 10:49:19 PST 
The flaky test looks all green after my latest change.
Comment 10 Jonathan Bedard 2020-01-14 11:22:49 PST 
Looks good so far...still need a few more test runs to be confident.
Comment 11 Jonathan Bedard 2020-01-16 15:02:01 PST 
I think we can pretty confidently say things are fixed now.