Bug 206031 – [macOS] Issue sandbox extension to "com.apple.nesessionmanager" prior to 10.15

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

We currently issue an extension to "com.apple.nesessionmanager.content-filter" on macOS, but this should be "com.apple.nesessionmanager" prior to macOS 10.15.

[Radar WebKit Bug Importer]

<rdar://problem/58455467>

[Brent Fulgham]

Created attachment 387298 [details]
Patch

[Brent Fulgham]

Note: A new test that covers this behavior is part of Bug 206025.

[Brent Fulgham]

WK1 failure is due to bot unable to download content.
iOS-wk2 failure can't be related, since this code change is not compiled on iOS.

[Per Arne Vollan]

Comment on attachment 387298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387298&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:338
> +        SandboxExtension::createHandleForMachLookup("com.apple.nesessionmanager", WTF::nullopt, handle);

I believe you also need the sevice in the sandbox, in the mach lookup extension rule.

[Brent Fulgham]

(In reply to Per Arne Vollan from comment #5)
> Comment on attachment 387298 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387298&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:338
> > +        SandboxExtension::createHandleForMachLookup("com.apple.nesessionmanager", WTF::nullopt, handle);
> 
> I believe you also need the sevice in the sandbox, in the mach lookup
> extension rule.

Ah! Yes, you are right. I'll fix that.

[Brent Fulgham]

Created attachment 387347 [details]
Patch

[Per Arne Vollan]

Comment on attachment 387347 [details]
Patch

Great! R=me.

[Brent Fulgham]

Committed r254343: <https://trac.webkit.org/changeset/254343>