Bug 206021 - Remove com.apple.locationd.registration from the WebContent sandbox
Summary: Remove com.apple.locationd.registration from the WebContent sandbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-09 11:46 PST by Brent Fulgham
Modified: 2020-01-10 12:40 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.45 KB, patch)
2020-01-09 12:16 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (5.69 KB, patch)
2020-01-09 17:26 PST, Brent Fulgham
pvollan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-01-09 11:46:50 PST
Now that we generate a dynamic extension for 'com.apple.locationd.registration', we should remove the blanket allow rule from the sandbox.
Comment 1 Radar WebKit Bug Importer 2020-01-09 11:47:10 PST
<rdar://problem/58451384>
Comment 2 Brent Fulgham 2020-01-09 12:16:52 PST
Created attachment 387253 [details]
Patch
Comment 3 Per Arne Vollan 2020-01-09 12:56:50 PST
Should we also add a test?
Comment 4 Brent Fulgham 2020-01-09 14:23:27 PST
(In reply to Per Arne Vollan from comment #3)
> Should we also add a test?

Good point!
Comment 5 Brent Fulgham 2020-01-09 17:26:41 PST
Created attachment 387295 [details]
Patch
Comment 6 Per Arne Vollan 2020-01-09 17:38:38 PST
Comment on attachment 387295 [details]
Patch

Nice! R=me.
Comment 7 Brent Fulgham 2020-01-10 12:39:38 PST
Committed r254363: <https://trac.webkit.org/changeset/254363>
Comment 8 Brent Fulgham 2020-01-10 12:40:44 PST
Note: The test failures are due to bot issues:

api-mac: The change to the iOS sandbox does not impact this system.
Mac-debug-wk1: The change to the iOS sandbox does not impact this system.
api-ios: API tests are run on simulator, which does not use the iOS sandbox.