Bug 206020 – Remove AGXCompilerService access from the WebContent sandbox

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brent Fulgham]

Now that we generate a dynamic extension for 'com.apple.AGXCompilerService', we should remove the blanket allow rule from the sandbox.

[Radar WebKit Bug Importer]

<rdar://problem/58451395>

[Brent Fulgham]

Created attachment 387251 [details]
Patch

[Per Arne Vollan]

Should we also add a test case for this in fast/sandbox/ios/sandbox-mach-lookup.html?

[Brent Fulgham]

(In reply to Per Arne Vollan from comment #3)
> Should we also add a test case for this in
> fast/sandbox/ios/sandbox-mach-lookup.html?

Since this is hardware specific, will we have too many test failures?

Is there a way to skip on specific hardware? I think we only support version and platform (not 2017 iPad versus 2018 iPad, for example).

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #4)
> (In reply to Per Arne Vollan from comment #3)
> > Should we also add a test case for this in
> > fast/sandbox/ios/sandbox-mach-lookup.html?
> 
> Since this is hardware specific, will we have too many test failures?
> 
> Is there a way to skip on specific hardware? I think we only support version
> and platform (not 2017 iPad versus 2018 iPad, for example).

You're right, I don't think there is a way to skip specific hardware.

[Per Arne Vollan]

Comment on attachment 387251 [details]
Patch

Great! R=me.

[WebKit Commit Bot]

Comment on attachment 387251 [details]
Patch

Clearing flags on attachment: 387251

Committed r254306: <https://trac.webkit.org/changeset/254306>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.