Bug 206020 - Remove AGXCompilerService access from the WebContent sandbox
Summary: Remove AGXCompilerService access from the WebContent sandbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-09 11:44 PST by Brent Fulgham
Modified: 2020-01-09 15:18 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2020-01-09 12:09 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-01-09 11:44:12 PST 
Now that we generate a dynamic extension for 'com.apple.AGXCompilerService', we should remove the blanket allow rule from the sandbox.
Comment 1 Radar WebKit Bug Importer 2020-01-09 11:47:25 PST 
<rdar://problem/58451395>
Comment 2 Brent Fulgham 2020-01-09 12:09:45 PST 
Created attachment 387251 [details]
Patch
Comment 3 Per Arne Vollan 2020-01-09 13:21:48 PST 
Should we also add a test case for this in fast/sandbox/ios/sandbox-mach-lookup.html?
Comment 4 Brent Fulgham 2020-01-09 14:06:05 PST 
(In reply to Per Arne Vollan from comment #3)
> Should we also add a test case for this in
> fast/sandbox/ios/sandbox-mach-lookup.html?

Since this is hardware specific, will we have too many test failures?

Is there a way to skip on specific hardware? I think we only support version and platform (not 2017 iPad versus 2018 iPad, for example).
Comment 5 Per Arne Vollan 2020-01-09 14:11:28 PST 
(In reply to Brent Fulgham from comment #4)
> (In reply to Per Arne Vollan from comment #3)
> > Should we also add a test case for this in
> > fast/sandbox/ios/sandbox-mach-lookup.html?
> 
> Since this is hardware specific, will we have too many test failures?
> 
> Is there a way to skip on specific hardware? I think we only support version
> and platform (not 2017 iPad versus 2018 iPad, for example).

You're right, I don't think there is a way to skip specific hardware.
Comment 6 Per Arne Vollan 2020-01-09 14:12:01 PST 
Comment on attachment 387251 [details]
Patch

Great! R=me.
Comment 7 WebKit Commit Bot 2020-01-09 15:18:12 PST 
Comment on attachment 387251 [details]
Patch

Clearing flags on attachment: 387251

Committed r254306: <https://trac.webkit.org/changeset/254306>
Comment 8 WebKit Commit Bot 2020-01-09 15:18:14 PST 
All reviewed patches have been landed.  Closing bug.