Text manipulation controller should not observe changes in new replacement elements

[Wenson Hsieh]

<rdar://problem/58353667>

[Wenson Hsieh]

Created attachment 387267 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 387267 [details]
Patch

Clearing flags on attachment: 387267

Committed r254314: <https://trac.webkit.org/changeset/254314>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

Comment on attachment 387267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387267&action=review

> Source/WebCore/editing/TextManipulationController.cpp:407
> +    m_document->eventLoop().queueTask(TaskSource::InternalAsyncTask, [weakThis = makeWeakPtr(*this)] {

Hm... this is probably not sufficient delay. We need to schedule this when the first call to didCreateRendererForElement happens.
Anyway, I'm gonna add a generic mechanism to track already translated content so it's sort of a moot point.

[Ryosuke Niwa]

(In reply to Ryosuke Niwa from comment #4)
> Comment on attachment 387267 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387267&action=review
> 
> > Source/WebCore/editing/TextManipulationController.cpp:407
> > +    m_document->eventLoop().queueTask(TaskSource::InternalAsyncTask, [weakThis = makeWeakPtr(*this)] {
> 
> Hm... this is probably not sufficient delay. We need to schedule this when
> the first call to didCreateRendererForElement happens.
> Anyway, I'm gonna add a generic mechanism to track already translated
> content so it's sort of a moot point.

This is because there is no guarantee that the style recalc happens by the next task in the event loop is executed.