Bug 206008 - [LFC] Rename UsedHorizontal(Vertical)Values to OverrideHorizontal(Vertical)values
Summary: [LFC] Rename UsedHorizontal(Vertical)Values to OverrideHorizontal(Vertical)va...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-09 07:49 PST by zalan
Modified: 2020-01-09 10:40 PST (History)
5 users (show)

See Also:


Attachments
Patch (46.83 KB, patch)
2020-01-09 08:11 PST, zalan
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-01-09 07:49:27 PST
ssia
Comment 1 Radar WebKit Bug Importer 2020-01-09 07:49:49 PST
<rdar://problem/58443375>
Comment 2 zalan 2020-01-09 08:11:38 PST
Created attachment 387231 [details]
Patch
Comment 3 Antti Koivisto 2020-01-09 08:15:04 PST
Comment on attachment 387231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387231&action=review

> Source/WebCore/ChangeLog:16
> +        values for the "compute geometry" functions (e.g. computing the width of a floating box follows
> +        the same set of steps as computing the width of an inline replaced box. So whenever we need to
> +        compute the width of a floating box, we could just call the computeInlineReplacedWidth() function.
> +        However their horizontal margin computations are different and since width and horizontal margins are being computed together,
> +        we need to make sure that inlineReplacedWidthAndMargin() takes a set of pre-computed margin values
> +        and uses them while computing the width value. Same applies to min/max-width/heigh computations.)

One day you'll put the entire ChangeLog entry inside parentheses.
Comment 4 zalan 2020-01-09 08:18:09 PST
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 387231 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387231&action=review
> 
> > Source/WebCore/ChangeLog:16
> > +        values for the "compute geometry" functions (e.g. computing the width of a floating box follows
> > +        the same set of steps as computing the width of an inline replaced box. So whenever we need to
> > +        compute the width of a floating box, we could just call the computeInlineReplacedWidth() function.
> > +        However their horizontal margin computations are different and since width and horizontal margins are being computed together,
> > +        we need to make sure that inlineReplacedWidthAndMargin() takes a set of pre-computed margin values
> > +        and uses them while computing the width value. Same applies to min/max-width/heigh computations.)
> 
> One day you'll put the entire ChangeLog entry inside parentheses.
That's one of my 2020 resolutions.
Comment 5 zalan 2020-01-09 10:40:03 PST
Committed r254277: <https://trac.webkit.org/changeset/254277>