Bug 205996 – Fix various non-unified build issues introduced since r253538

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adrian Perez]

First set of fixes for non-unified builds in 2020 :-]

[Adrian Perez]

Created attachment 387225 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 387225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387225&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        [GTK][WPE] Fix various non-unified build issues introduced since r253538

Why is this marked GTK and WPE specific?

[Adrian Perez]

(In reply to Carlos Garcia Campos from comment #2)
> Comment on attachment 387225 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387225&action=review
> 
> > Source/JavaScriptCore/ChangeLog:3
> > +        [GTK][WPE] Fix various non-unified build issues introduced since r253538
> 
> Why is this marked GTK and WPE specific?

Right… no reason whatsoever. Let's remove the tags.

[youenn fablet]

Comment on attachment 387225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387225&action=review

> Source/WebCore/page/PageConfiguration.h:34
> +#include <wtf/text/WTFString.h>

Would <wtf/Forward.h> work here?

[Adrian Perez]

(In reply to youenn fablet from comment #4)
> Comment on attachment 387225 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387225&action=review
> 
> > Source/WebCore/page/PageConfiguration.h:34
> > +#include <wtf/text/WTFString.h>
> 
> Would <wtf/Forward.h> work here?

I'll give that a try, thanks for the suggestion.

[Adrian Perez]

(In reply to Adrian Perez from comment #5)
> (In reply to youenn fablet from comment #4)
> > Comment on attachment 387225 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=387225&action=review
> > 
> > > Source/WebCore/page/PageConfiguration.h:34
> > > +#include <wtf/text/WTFString.h>
> > 
> > Would <wtf/Forward.h> work here?
> 
> I'll give that a try, thanks for the suggestion.

Yes, using <wtf/Forward.h> instead of <wtf/text/WTFString.h> worked.
I'll land a version of the patch with this change applied and the
bug title adjusted as per Carlos' suggestion.

As there are mentions to files NarrowingNumberPredictionFuzzerAgent.cpp
and NarrowingNumberPredictionFuzzerAgent.cpp which contain the string
“fuzzer” in them, the style checker complains, so I will land the patch
manually after checking that the EWS bots build with the patch fine :)

[Adrian Perez]

Created attachment 387269 [details]
Patch for landing

[Adrian Perez]

Committed r254327: <https://trac.webkit.org/changeset/254327>

[Radar WebKit Bug Importer]

<rdar://problem/58471112>